Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEXP-625 - Report affected instance when export contains negative number of failed records #370

Merged
merged 13 commits into from
Sep 14, 2023

Conversation

obozhko-folio
Copy link
Contributor

@obozhko-folio obozhko-folio commented Sep 1, 2023

MDEXP-625 - Report affected instance when export contains negative number of failed records

Purpose

Handle duplicated SRS records.

Approach

Modify schema for Progress and replace failed (integer) with Failed (object), which contains both of failed and duplicated fields.

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?

    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?

    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@obozhko-folio obozhko-folio marked this pull request as ready for review September 4, 2023 19:16
@obozhko-folio obozhko-folio requested a review from a team September 4, 2023 19:16
@obozhko-folio obozhko-folio self-assigned this Sep 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.1% 85.1% Coverage
0.0% 0.0% Duplication

@obozhko-folio obozhko-folio merged commit 9395d1f into master Sep 14, 2023
6 checks passed
@obozhko-folio obozhko-folio deleted the MDEXP-625 branch September 14, 2023 11:13
dmytrokrutii pushed a commit to dmytrokrutii/mod-data-export that referenced this pull request Sep 26, 2024
…r "Titles fields to export" are without chosen options in multi-select (folio-org#370)

* MODEXPW-318 - fixed NPE

* MODEXPW-318 - refactored

* MODEXPW-318 - fixed bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants