Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move fmt_detail namespace under the main fmt namespace #4328

Closed
wants to merge 1 commit into from
Closed

move fmt_detail namespace under the main fmt namespace #4328

wants to merge 1 commit into from

Conversation

odygrd
Copy link

@odygrd odygrd commented Jan 26, 2025

No description provided.

@odygrd odygrd mentioned this pull request Jan 26, 2025
Open
@odygrd odygrd force-pushed the fmt_detail_namespace branch from 5686aad to 6b54860 Compare January 26, 2025 18:39
@odygrd
Copy link
Author

odygrd commented Jan 26, 2025

This turned out to be more complicated than I initially thought. 😞
When fmt_detail is nested inside the fmt namespace, it seems to take precedence over std::chrono. Adding using std::chrono::current_zone appears to fix the issue at least when trying on windows, but it seems like we'd need an additional preprocessor check specifically for C++20.
Given the added complexity, I think it’s not worth pursuing this further at the moment. Closing this for now.

@odygrd odygrd closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@odygrd