Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chrono-tz and some other packages and some cleanup #89

Merged
merged 10 commits into from
Apr 7, 2023
Merged

Conversation

omid
Copy link
Collaborator

@omid omid commented Mar 17, 2023

fixes #88

@omid omid requested a review from fmeringdal March 17, 2023 22:37
@fmeringdal
Copy link
Owner

Thanks @omid ! Will review these changes next week

Copy link
Owner

@fmeringdal fmeringdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, left some comments. Regarding unwrap -> expect for non-test code, it might be worth to try adding this to the crate root if it doesn't add to many complaints

#![cfg_attr(not(test), deny(clippy::unwrap_used))] // Not sure if syntax is correct tho! 

.github/workflows/ci.yml Show resolved Hide resolved
rrule/src/iter/counter_date.rs Show resolved Hide resolved
rrule/src/iter/iterinfo.rs Show resolved Hide resolved
rrule/src/iter/iterinfo.rs Show resolved Hide resolved
rrule/src/iter/utils.rs Show resolved Hide resolved
rrule/src/iter/yearinfo.rs Show resolved Hide resolved
rrule/src/iter/yearinfo.rs Show resolved Hide resolved
rrule/src/validator/validate_rrule.rs Show resolved Hide resolved
deny.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@omid

This comment was marked as resolved.

.cargo/config.toml Outdated Show resolved Hide resolved
@fmeringdal
Copy link
Owner

@omid Looks good to merge now. I know the commit history in this repo is terrible, but let us try to improve it moving forward. Could you please squash the commits and we can merge + release? Thanks!

@omid
Copy link
Collaborator Author

omid commented Apr 6, 2023

@fmeringdal we can use the squash and merge feature of GitHub 👍

@fmeringdal
Copy link
Owner

True, but I don't think the squashed commit message would be particularly nice. Something like this would be great:

"Prepare 0.11 release by updating chrono-tz
Additionally, this commit includes:

  • Bumping MSRV to v1.64.0
  • Temporarily allows clippy warnings in CI
  • General cleanup work"

Wdyt?

@omid omid merged commit 8f4411f into main Apr 7, 2023
@omid
Copy link
Collaborator Author

omid commented Apr 7, 2023

You can set the commit message in GitHub also. Like what I just did 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update chrono-tz dependency or allow for broader dependency version
2 participants