-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chrono-tz and some other packages and some cleanup #89
Conversation
Thanks @omid ! Will review these changes next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, left some comments. Regarding unwrap -> expect for non-test code, it might be worth to try adding this to the crate root if it doesn't add to many complaints
#![cfg_attr(not(test), deny(clippy::unwrap_used))] // Not sure if syntax is correct tho!
This comment was marked as resolved.
This comment was marked as resolved.
@omid Looks good to merge now. I know the commit history in this repo is terrible, but let us try to improve it moving forward. Could you please squash the commits and we can merge + release? Thanks! |
@fmeringdal we can use the squash and merge feature of GitHub 👍 |
True, but I don't think the squashed commit message would be particularly nice. Something like this would be great: "Prepare 0.11 release by updating
Wdyt? |
You can set the commit message in GitHub also. Like what I just did 🙈 |
fixes #88