Disable memoize on string refinement method

Its causing all the specs to fail, however I was not able to figure out why it was doing so...
flyerhzm · Jan 21, 2025 · 42d2473 · 42d2473
1 parent b10ed99
commit 42d2473
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lib/bullet/detector/n_plus_one_query.rb b/lib/bullet/detector/n_plus_one_query.rb
@@ -48,6 +48,7 @@ def add_possible_objects(object_or_objects)
             end
             obj.bullet_key
           end.join(", ")
+
           unless class_names_match_regex || primary_key_values_are_empty
             Bullet.debug('Detector::NPlusOneQuery#add_possible_objects', "objects: #{keys_joined}")
             objects.each { |object| possible_objects.add object.bullet_key }

diff --git a/lib/bullet/ext/string.rb b/lib/bullet/ext/string.rb
@@ -4,13 +4,9 @@ module Bullet
   module Ext
     module String
       refine ::String do
-        attr_reader :bullet_class_name
-
         def bullet_class_name
-          @bullet_class_name ||= begin
-            last_colon = self.rindex(':')
-            last_colon ? self[0...last_colon] : self
-          end
+          last_colon = self.rindex(':')
+          last_colon ? self[0...last_colon].dup : self.dup
         end
       end
     end