export-db/pop-db: extend functionality to return more data, allow import of any table in database
#534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
added
improvement
Problem: The export-db and pop-db commands only handle a couple of columns from just the association_table and bank_table. These commands would be more robust if they included export and import support from all of the tables. Restructure the export_db_info() function to return data from *all* of the tables in the flux-accounting DB into separate .csv files, labeled with their table names in the database. Restructure the populate_db() function to handle populating any of the tables in the flux-accounting DB with a corresponding .csv file. Add an optional argument to the function to allow the user to specify which columns to include from the file when populating the table.
Problem: The sharness tests for the pop-db and export-db commands are out-of-date in a couple of ways: - their filenames are not those of the actual table names in the flux-accounting database - they do not include the column names in the first line of the .csv file - the pop-db command no longer has a "--users" optional argument to specify a file containing data for the association_table Update the tests accordingly to account for the improvements made to the export-db and pop-db commands.
cmoussa1
force-pushed
the
restructure.db-info
branch
from
14c8cbd to
b80bcbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
export-dbandpop-dbcommands only handle a couple of columns from just theassociation_tableandbank_table. These commands would be more robust if they included export and import support from all of the tables.This PR restructures the
export_db_info()function to return data from all of the tables in the flux-accounting DB into separate.csvfiles, labeled with their table names in the database. It also restructures thepopulate_db()function to handle populating any of the tables in the flux-accounting DB with a corresponding.csvfile. It adds an optional argument to the command which allows the user to specify which columns to include from the file when populating the table.As a result of the improvements made to both functions, I've also restructured the tests for both of these commands slightly, mostly just:
.csvfiles--banksand--usersoptional arguments