Fixed ui bugs (#931)

## Description Fixed ui bugs #434 1. crane - russian tabs text goes out of bounds (Fixed by making it scrollable) 2. shrine - glow effect is not lined up with the box angle, or clipped, thus goes out of the box (see top left area of the screenshot) (Not Fixed have suggestion) 3. settings menu - safe area at the top is not applied (Fixed) 4. reply - back button at the top goes under the status bar (was Already Fixed) 5. reply - bottom sheet is not scrollable (Was Already Fixed) ## Tests *Please describe the tests that you added or updated to verify your changes.* ## Issues 1. crane - russian tabs text goes out of bounds 2. shrine - glow effect is not lined up with the box angle, or clipped, thus goes out of the box (see top left area of the screenshot) 3. settings menu - safe area at the top is not applied 4. reply - back button at the top goes under the status bar 5. reply - bottom sheet is not scrollable --- ![Screenshot_1681559143](https://user-images.githubusercontent.com/96950460/232219286-80e71853-cd94-4304-904a-c542c993a6d7.png)![Screenshot_1681556066](https://user-images.githubusercontent.com/96950460/232219265-081e6f98-338b-4ae9-9267-e6cf81e23742.png) ![Screenshot_1681558945](https://user-images.githubusercontent.com/96950460/232219276-779485e9-eb46-4533-a4fe-2e4cded76919.png) ![Screenshot_1681559136](https://user-images.githubusercontent.com/96950460/232219280-33781539-0bc7-4813-a548-b56346779ad1.png)
flutter · Apr 20, 2023 · c8872d2 · c8872d2
1 parent 4fd9e18
commit c8872d2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/lib/pages/backdrop.dart b/lib/pages/backdrop.dart
@@ -221,10 +221,14 @@ class _BackdropState extends State<Backdrop> with TickerProviderStateMixin {
               ),
             ),
           ],
-          _SettingsIcon(
-            animationController: _iconController,
-            toggleSettings: _toggleSettings,
-            isSettingsOpenNotifier: _isSettingsOpenNotifier,
+          Positioned(
+            top: 12,
+            right: 0,
+            child: _SettingsIcon(
+              animationController: _iconController,
+              toggleSettings: _toggleSettings,
+              isSettingsOpenNotifier: _isSettingsOpenNotifier,
+            ),
           ),
         ],
       ),

diff --git a/lib/studies/crane/backdrop.dart b/lib/studies/crane/backdrop.dart
@@ -356,13 +356,12 @@ class _CraneAppBarState extends State<CraneAppBar> {
                       textScaleFactor: textScaleFactor,
                     ),
                     controller: widget.tabController,
-                    labelPadding: isDesktop
-                        ? const EdgeInsets.symmetric(horizontal: 32)
-                        : EdgeInsets.zero,
-                    isScrollable: isDesktop,
+                    labelPadding: const EdgeInsets.symmetric(horizontal: 32),
+                    isScrollable: true,
                     // left-align tabs on desktop
                     labelStyle: Theme.of(context).textTheme.labelLarge,
                     labelColor: cranePrimaryWhite,
+                    physics: const BouncingScrollPhysics(),
                     unselectedLabelColor: cranePrimaryWhite.withOpacity(.6),
                     onTap: (index) => widget.tabController.animateTo(
                       index,

diff --git a/lib/studies/shrine/supplemental/asymmetric_view.dart b/lib/studies/shrine/supplemental/asymmetric_view.dart
@@ -153,7 +153,7 @@ class MobileAsymmetricView extends StatelessWidget {
                   16,
                   _bottomPadding,
                 ),
-                physics: const AlwaysScrollableScrollPhysics(),
+                physics: const BouncingScrollPhysics(),
                 children: _buildColumns(context, constraints),
               );
             },