Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GA Analytics #7760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jwren
Copy link
Member

@jwren jwren commented Nov 4, 2024

No description provided.

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to remove all this? I thought the plan was to replace legacy analytics with unified analytics events. Removing all the analytics event send sites would require that we add them all back with unified analytics instead of just swapping the logic to send through unified analytics package instead of through the legacy GA.

@jwren
Copy link
Member Author

jwren commented Nov 4, 2024

Acknowledged and we can discuss more if you want. The counter argument though is that the Analytics API was designed with a GA-first mind set, and especially as time went on, the APIs were not called consistently, nor everywhere where we want them called from. I imagine that this PR will be used when the better analytics goes in, but now we'll have a clean history to improve code health and ultimately a better analytics story for the plugin.

@kenzieschmoll
Copy link
Member

Ack. Do we still show the unified analytics prompt coming from the analysis server after this change? CC @bwilkerson As long as we are not removing that logic, then it's probably fine to remove all this.

@jwren
Copy link
Member Author

jwren commented Nov 11, 2024

Note: don't commit yet, the Flutter preference page has an issue with this PR, it needs to be fixed before this can land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants