Feature/hub 1565 #1413
Open
Feature/hub 1565 #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the user for HUB-1565
…the user for HUB-1565
allustag
requested changes
Oct 17, 2024
| @@ -131,6 +131,11 @@ public Response createChannel(@PathParam("channel") String channelName, String j | |||
| log.trace("put channel {} {}", channelName, json); | |||
| Optional<ChannelConfig> oldConfig = channelService.getChannelConfig(channelName, false); | |||
| ChannelConfig channelConfig = ChannelConfig.createFromJsonWithName(json, channelName); | |||
| if (channelConfig.getCreationDate()!= null) { | |||
| // If the creation date is being modified, throw a 500 error | |||
| return Response.status(Response.Status.INTERNAL_SERVER_ERROR) | |||
There was a problem hiding this comment.
@Haripriya99j As informed earlier, don't introduce new logic instead make use of existing logic. Also, this logic will unnecessarily return error message while creating with creationDate but that is not the requirement. Below is the class already available to perform validation and returns error message. See how we can use make use of it.
https://github.com/flightstats/hub/blob/feature/HUB-1565/src/main/java/com/flightstats/hub/channel/ChannelValidator.java
Write test cases as well to ensure it is working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.