Feat/update rn 0.76.5 #1838
Open
Feat/update rn 0.76.5 #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+60
to
+62
| `node ${doResolve(c.runtime.runtimeExtraProps?.reactNativePackageName || 'react-native')}/cli.js ${args.join( | ||
| ' ' | ||
| )} --config=${c.runtime.runtimeExtraProps?.reactNativeMetroConfigName || 'metro.config.js'}`, |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 5 days ago
To fix the problem, we should avoid constructing the shell command as a single string and instead use child_process.spawn or child_process.execFile to pass the command and its arguments as an array. This approach ensures that each argument is treated as a separate entity, preventing shell interpretation of special characters.
- Replace the string concatenation with an array of arguments.
- Use
child_process.spawnto execute the command with the arguments array.
Suggested changeset
1
packages/sdk-react-native/src/iosRunner.ts
| @@ -58,6 +58,11 @@ | ||
| } | ||
| const command = 'node'; | ||
| const commandArgs = [ | ||
| `${doResolve(c.runtime.runtimeExtraProps?.reactNativePackageName || 'react-native')}/cli.js`, | ||
| ...args, | ||
| `--config=${c.runtime.runtimeExtraProps?.reactNativeMetroConfigName || 'metro.config.js'}`, | ||
| ]; | ||
| return executeAsync( | ||
| `node ${doResolve(c.runtime.runtimeExtraProps?.reactNativePackageName || 'react-native')}/cli.js ${args.join( | ||
| ' ' | ||
| )} --config=${c.runtime.runtimeExtraProps?.reactNativeMetroConfigName || 'metro.config.js'}`, | ||
| command, | ||
| commandArgs, | ||
| { |
Copilot is powered by AI and may make mistakes. Always verify output.
locksten
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Platforms that works:
Related issues
Npm releases
n/a