Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added whitelist functionality #71

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added whitelist functionality #71

wants to merge 5 commits into from

Conversation

Jenyyk
Copy link

@Jenyyk Jenyyk commented Nov 30, 2024

Pretaining to #26
PROS:

  • it works during usage (while not switching modes)

CONS:

  • when switching between blacklist / whitelist, does not automatically update the effect
    • needs to be somehow kickstarted, eg. by flipping around the skip LibAdwaita/LibHandy buttons
  • when switching between blacklist / whitelist, sometimes freezes my computer

flexagoon
flexagoon requested changes Dec 17, 2024
View reviewed changes
src/manager/utils.ts Outdated Show resolved Hide resolved
src/preferences/pages/blacklist.ui Outdated Show resolved Hide resolved
src/preferences/pages/blacklist.ui Outdated Show resolved Hide resolved
src/preferences/pages/blacklist.ui Outdated Show resolved Hide resolved
@Jenyyk
Copy link
Author

Jenyyk commented Dec 17, 2024

4 new commits to address all requested changes

@Jenyyk Jenyyk requested a review from flexagoon December 17, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexagoon flexagoon Awaiting requested review from flexagoon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jenyyk @flexagoon