Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention policy automation side effects of VPP token deletion/reassignment #25584

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Jan 18, 2025

For #23115. Review requested from @marko-lisica per @noahtalerman's response to @jmwatts's comment on the ticket.

Skipping changes file as this is part of the larger feature and treated as an unreleased bug for change management purposes, assuming the copy revision looks good (or the copy revision looks good after more modifications). Will assign a dev reviewer once copy looks good, if we decide we want the copy here (vs. in docs).

@marko-lisica set for review to confirm whether we need this/whether the copy looks good. @jmwatts set for review to confirm this is what she had in mind for feedback. Of note, deleting a VPP token does not cancel pending installs since at that point the MDM command is already sent, so we don't need that verbiage here.

Edit VPP token teams

Before

image

After

image

Delete VPP token

Before

image

After

image

Checklist for submitter

  • Manual QA for all new/changed functionality

@iansltx iansltx requested a review from a team as a code owner January 18, 2025 06:13
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.61%. Comparing base (240c131) to head (5330b68).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25584   +/-   ##
=======================================
  Coverage   63.60%   63.61%           
=======================================
  Files        1620     1620           
  Lines      155081   155081           
  Branches     3985     4036   +51     
=======================================
+ Hits        98644    98651    +7     
+ Misses      48666    48659    -7     
  Partials     7771     7771           
Flag Coverage Δ
frontend 53.22% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant