Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI – Updates to confirm invite flow #25583

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

UI – Updates to confirm invite flow #25583

wants to merge 9 commits into from
+175 −112

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Jan 18, 2025 •
edited
Loading

TODO - form validation

For #24486

  • Check invite validity before rendering form, error if invalid
  • Use data returned from validity check to pre-populate form
  • Remove dependence of flow on URL params other than token
  • Remove other URL params from link generated in invite confirmation email
  • Refactor form from JS to TS
  • Refactor form from class to functional components
  • Cleanup unused logic
  • Improve error handling

Invalid invite
invalid

Valid invite
valid-login-flow

  • Changes file added for user-visible changes in changes/
  • Updated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Jacob Shandling added 9 commits January 17, 2025 14:02
Most updates to confirm invite flow
f2ef840 
- Remove dependence on url params other than token
- Spinner while using token to check server for invite validity
- Use returned data with valid invites
- Refactor JS –> TS
- Refactor class –> functional components
- Clean up
remove name and email from invite link
8efddf1
small cleanup
c47f038
include all data in API POST
3066bc2
stabilize onSubmit, use correct button type
728e008
better error flash on server error
131cc2a
add disclaimer to frontend patterns
42df342
change file
4a635dd
slight cleanup
ac5e9e8
@jacobshandling jacobshandling requested review from a team as code owners January 18, 2025 00:45
@jacobshandling jacobshandling marked this pull request as draft January 18, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobshandling