-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use safelist(s), allowlist(s) where applicable #158
Conversation
Thank you for submitting this! Renaming classes was already on my roadmap (see #155 for how I was planning to approach it along with some backwards-compatibility concerns) so I'm totally aligned on the intention. Give me a few days to find some time to understand the changes made here and look at the failing tests. I'm a little under water at the moment. |
Apologies for the long response time here -- the last few weeks have been hectic for me. This is still on my TODO list and I intend to get to it as soon as I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment, the rest is 👍 :)
Rakefile
Outdated
task :generate_whitelists do | ||
load "tasks/generate-whitelists" | ||
desc "generate allowlists from W3C specifications" | ||
task :generate_allowlists do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why allowlist
here instead of safelist
?
Introducing a second term for the same concept does not seem right here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just an update: I'm struggling to find time to work on OSS; this is still something I'm very keen to do, so thanks for your patience. |
Hi! I apologize for this going so long without review. I'm dedicating some time this week to my open source projects and will spend some time with this PR. Thank you again for sending such a thoughtful PR. |
Closing in favor of #164. |
v2.3.0 has been released. |
Offensive? “Blacklist” is not race related, either in origin or context. “Whitelist“ is it’s opposite. https://www.reddit.com/r/AskHistorians/comments/866ynp/what_are_the_origins_of_the_words_blacklist_and/ |
This Pull Request updates:
rake generate_allowlists
Safelist, allowlist is easier to understand and less offensive.
Original motivation, other community efforts examples: