client: Fix push command with aiohttp >= 3.10.6 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In aiohttp 3.10.6 aio-libs/aiohttp#6485 a new abstract method was implemented in aiohttp.Payload. So trying to instantiate the AsyncNamedFilePart class fails and causes the push command to fail: ``` File "/usr/sbin/flat-manager-client", line 350, in upload_objects named = get_object_multipart(repo_path, file_obj) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/sbin/flat-manager-client", line 738, in get_object_multipart return AsyncNamedFilePart( ^^^^^^^^^^^^^^^^^^^ TypeError: Can't instantiate abstract class AsyncNamedFilePart without an implementation for abstract method 'decode' ``` Create a placeholder method for now.
bbhtt
force-pushed
the
bbhtt/aiohttp-compat
branch
from
3dc7768 to
7c1bd96
Compare
This is used in org.flatpak.Builder now, so CI should test against 24.08
bbhtt
force-pushed
the
bbhtt/aiohttp-compat
branch
2 times, most recently
from
83f5ab4 to
e034b0f
Compare
Usage dropped in ac62ecb
bbhtt
force-pushed
the
bbhtt/aiohttp-compat
branch
from
e034b0f to
cf78610
Compare
bhearsum
added a commit
to bhearsum/scriptworker-scripts
that referenced
this pull request
Nov 22, 2024
This is to grab flatpak/flat-manager#139, which ought to fix the bustage we saw in https://bugzilla.mozilla.org/show_bug.cgi?id=1932766 caused by an upgrade to aiohttp.
bhearsum
added a commit
to bhearsum/scriptworker-scripts
that referenced
this pull request
Nov 25, 2024
This is to grab flatpak/flat-manager#139, which ought to fix the bustage we saw in https://bugzilla.mozilla.org/show_bug.cgi?id=1932766 caused by an upgrade to aiohttp.
bhearsum
added a commit
to bhearsum/scriptworker-scripts
that referenced
this pull request
Nov 25, 2024
This is to grab flatpak/flat-manager#139, which ought to fix the bustage we saw in https://bugzilla.mozilla.org/show_bug.cgi?id=1932766 caused by an upgrade to aiohttp.
bhearsum
added a commit
to mozilla-releng/scriptworker-scripts
that referenced
this pull request
Nov 25, 2024
This is to grab flatpak/flat-manager#139, which ought to fix the bustage we saw in https://bugzilla.mozilla.org/show_bug.cgi?id=1932766 caused by an upgrade to aiohttp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In aiohttp 3.10.6 aio-libs/aiohttp#6485 a new
abstract method was implemented in aiohttp.Payload. So trying to
instantiate the AsyncNamedFilePart class fails and causes the push
command to fail:
Create a placeholder method for now.