Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make python FFT=DUCC" uses FFTW #585

Open
mreineck opened this issue Oct 23, 2024 · 1 comment · May be fixed by #586
Open

"make python FFT=DUCC" uses FFTW #585

mreineck opened this issue Oct 23, 2024 · 1 comment · May be fixed by #586
Assignees
@ahbarnett

Comments

@mreineck
Copy link
Collaborator

Just a minor thing I noticed: it seems that the build process for the Python package uses cmake, even if the build is requested via make python. As a consequence, the option "FFT=DUCC" doesn't seem to be passed through to cmake.

Not sure how to fix this. It would be nice if it worked, but it's definitely nothing urgent.
@ahbarnett ahbarnett self-assigned this Oct 25, 2024
@ahbarnett ahbarnett linked a pull request Oct 25, 2024 that will close this issue
Open
@ahbarnett ahbarnett assigned mreineck and unassigned mreineck Oct 25, 2024
@mreineck
Copy link
Collaborator Author

Thanks a lot, #586 fixes the problem for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahbarnett ahbarnett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

makefile: pass DUCC option to Python sk-build via CMAKE_ARGS in pip flatironinstitute/finufft
2 participants
@mreineck @ahbarnett