Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vulkan renderer initialization by symlinking libdl to /app/bin #171

Closed
wants to merge 1 commit into from
Closed

Conversation

jaydns
Copy link

@jaydns jaydns commented Apr 13, 2024

when the "vulkan (experimental)" renderer is selected, it tries looking for libdl.so in /app/bin/ but it only exists in /usr/lib/x86_64-linux-gnu/. adding a symlink fixes this issue
image

@flathubbot
Copy link
Contributor

Started test build 114395

@flathubbot
Copy link
Contributor

Build 114395 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97207/sh.ppy.osu.flatpakref

@peppy
Copy link
Collaborator

peppy commented Apr 14, 2024

cc @smoogipoo not sure if we want to do this here.

@smoogipoo
Copy link

smoogipoo commented Apr 14, 2024

I think we definitely don't want to do this. Everything should work fine if we use libdl.so.2, which is already relied on by ourselves (and other places) and Veldrid, and more.

In this case, the failing library is not one we own.

But the true solution is to not implement this in the first place, and use NativeLibrary instead. The failing library in question targets netstandard1.4 which didn't have this.

I'm fine with Vulkan being broken here for the time being - it's broken for a majority of users in other ways anyway.

@peppy peppy closed this Apr 15, 2024
@smoogipoo
Copy link

We are going to be fixing this ourselves, starting with ppy/vk#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants