Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suave #4

Merged
merged 60 commits into from
Nov 22, 2023
Merged

suave #4

merged 60 commits into from
Nov 22, 2023

Conversation

zeroXbrock
Copy link
Member

@zeroXbrock zeroXbrock commented Nov 2, 2023 •
edited
Loading 

# make sure you have suave-geth devnet running locally, and .env configured here:
cd examples/suave
vim .env
cd contracts

compile contracts:

# in examples/suave/contracts/
forge install
forge build

deploy mev-share bid contract:

# in examples/suave/
source .env
cd contracts
forge script --broadcast --rpc-url $SUAVE_RPC_URL_HTTP --private-key $PRIVATE_KEY DeployContracts

then populate your .env file with the new bid contract address (assuming your suave chain id is 16813125)

# in examples/suave/contracts/
echo "BID_CONTRACT_ADDRESS=$(cat broadcast/Deploy.s.sol/16813125/run-latest.json | jq -r '.receipts[0].contractAddress')" >> ../.env
cd -

then run the script:

bun run test:e2e

@zeroXbrock
remove CHANGELOG.md symlink
61c540e
@zeroXbrock
add transactionRequest test, update SuaveTransactionRequest definition
9b816dc
@zeroXbrock
add tx formatter
671a79a
@zeroXbrock
disable anvil calls in vitest setup (run with SKIP_GLOBAL_SETUP=true)
17b0fde
@zeroXbrock
add test:e2e in playgrounds/bun/
1e7a94b
@zeroXbrock
update chain id, add local devnet config
6f693e3
@zeroXbrock
working SuaveTransactionRequest impl
97c36e1
@zeroXbrock
infer isConfidential from confidentialInputs
71a6576
@zeroXbrock
infer tx type in SuaveTransactionRequest
7b61d6d
@zeroXbrock
add getTransaction[Receipt] to playground test
92fa84b
@zeroXbrock
revise SuaveTransaction formatter/type
af71ab8
@zeroXbrock
harden SuaveTransaction[Request] formatter/type
9c0d032
@zeroXbrock
add SuaveTransaction serialization constructs
b5cfd0e
@zeroXbrock
refactor type defs; make rpc types generic, deserialized types restri…
0de1318 
…ctive
@zeroXbrock
experimental serializer
84c8072
@zeroXbrock
fix rlp signature bugs; working CCR transactionRequests
51f382e
@zeroXbrock
push lint fixes
7e51c28
@zeroXbrock
cleanup, remove debug console logs
b2238c3
@zeroXbrock
compartmentalize wallet action overrides with new fn: getSuaveWallet
bff6fbd
@zeroXbrock
support all tx types
4f1c223
@zeroXbrock
remove bad 'from' addrs
951d93c
@zeroXbrock
lint
b6f70bc
@zeroXbrock
fix bad imports
e762187
@zeroXbrock
make privatekey optional in getSuaveWallet
ac62568
@zeroXbrock
lint
39bfd43
@zeroXbrock
fix some type-related bugs + formatter tests
91655de
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 57.93 KB (0%) 1.2 s (0%) 744 ms (+219.17% 🔺) 2 s
viem (cjs) 76.48 KB (0%) 1.6 s (0%) 816 ms (+76.68% 🔺) 2.4 s
viem (minimal surface - tree-shaking) 3.97 KB (0%) 80 ms (0%) 64 ms (-44.27% 🔽) 144 ms
viem/accounts 89.01 KB (0%) 1.8 s (0%) 467 ms (+33.95% 🔺) 2.3 s
viem/accounts (tree-shaking) 19.37 KB (0%) 388 ms (0%) 253 ms (-13.19% 🔽) 641 ms
viem/actions 43.25 KB (0%) 865 ms (0%) 2.7 s (-16.15% 🔽) 3.6 s
viem/actions (tree-shaking) 350 B (0%) 10 ms (0%) 101 ms (+54.7% 🔺) 111 ms
viem/chains 57.73 KB (+234.13% 🔺) 1.2 s (+234.13% 🔺) 904 ms (+218.93% 🔺) 2.1 s
viem/chains (tree-shaking) 470 B (0%) 10 ms (0%) 59 ms (-47.1% 🔽) 69 ms
viem/chains/utils 7.97 KB (0%) 160 ms (0%) 159 ms (+27.46% 🔺) 319 ms
viem/chains/utils (tree-shaking) 5.24 KB (0%) 105 ms (0%) 111 ms (-13.19% 🔽) 216 ms
viem/ens 43.25 KB (0%) 865 ms (0%) 3.6 s (+23.71% 🔺) 4.5 s
viem/ens (tree-shaking) 17.94 KB (0%) 359 ms (0%) 189 ms (-49.5% 🔽) 548 ms

@zeroXbrock zeroXbrock marked this pull request as draft November 2, 2023 22:39
@dmarzzz dmarzzz self-requested a review November 16, 2023 11:24
@zeroXbrock
clean up & fix bugs in serializer/signer
eeebe95 
- working ccRequest & contract deployment
- made example useless so it will compile
  - will fix this next
@zeroXbrock
cleanup
c79a4f0
@zeroXbrock
add deploy script for mev-share contract, clean up
830fbe4 
- deploy mev-share suave contract w/ forge
- convert index-style imports to tiny mod imports
- fix build errors from new type changes
@zeroXbrock
tighten up types
18a21a0
@zeroXbrock
clean up deploy script
7fa521e
@zeroXbrock
add working mev-share bid example in playgrounds/bun
1b2c842
@zeroXbrock
comment out old examples; saving for later isolated examples
f16e50b
@zeroXbrock
make chainId optional in TransactionRequestSuave
c83812f
@zeroXbrock
move getSuaveWallet to suaveRigil.newWallet
c29aec0
@zeroXbrock
move playground code to examples/suave/
ce252fb
@zeroXbrock
lint
e2eab53
@zeroXbrock
delete old code comments
899a5dc
@zeroXbrock
insert suave chainId if missing
d4236bc
dmarzzz
dmarzzz approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@dmarzzz dmarzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM

@zeroXbrock zeroXbrock merged commit fa23389 into main Nov 22, 2023
@zeroXbrock zeroXbrock deleted the brock/suave2 branch November 22, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarzzz dmarzzz dmarzzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeroXbrock @dmarzzz