Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add precompile httpRequest2 that returns whole response #286

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Add precompile httpRequest2 that returns whole response #286

merged 2 commits into from
Dec 4, 2024

Conversation

ferranbt
Copy link
Collaborator

@ferranbt ferranbt commented Dec 3, 2024

📝 Summary

This PR adds a new precompile to make http requests that returns the whole http response object.

  • I have seen and agree to CONTRIBUTING.md

zeroXbrock
zeroXbrock approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@zeroXbrock zeroXbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm! Thanks @ferranbt

@ferranbt ferranbt merged commit 06b7e72 into main Dec 4, 2024
4 checks passed
@ferranbt ferranbt deleted the ferranbt/httprequest2-precompile branch December 4, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroXbrock zeroXbrock zeroXbrock approved these changes

@Ruteri Ruteri Awaiting requested review from Ruteri Ruteri is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

@dmarzzz dmarzzz Awaiting requested review from dmarzzz dmarzzz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferranbt @zeroXbrock