Add nightly releases #200
Merged
Add nightly releases #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
Feb 19, 2024
| @@ -96,8 +96,8 @@ dockers: | |||
| - --platform=linux/amd64 | |||
| image_templates: | |||
| - "flashbots/suave-geth:{{ .ShortCommit }}-amd64" | |||
| - "flashbots/suave-geth:{{ .Tag }}-amd64" | |||
| - "flashbots/suave-geth:latest-amd64" | |||
| - "flashbots/suave-geth:v{{ .Version }}-amd64" | |||
There was a problem hiding this comment.
It was using Tag before, but it needs to use Version because that is the field that the nightly section overrides during nightly releases.
ferranbt
commented
Feb 19, 2024
.goreleaser.yaml
Outdated
| @@ -123,6 +123,12 @@ docker_manifests: | |||
| - "flashbots/suave-geth:latest-amd64" | |||
There was a problem hiding this comment.
Not sure If I have to do something with this @0x416e746f6e
There was a problem hiding this comment.
yes, I think this whole block should look like:
{{- if not .IsNightly }}
- name_template: "flashbots/suave-geth:latest"
image_templates:
- "flashbots/suave-geth:latest-amd64"
- "flashbots/suave-geth:latest-arm64"
{{ else }}
- name_template: "flashbots/suave-geth:latest-nightly"
image_templates:
- "flashbots/suave-geth:latest-nightly-amd64"
- "flashbots/suave-geth:latest-nightly-arm64"
{{- end }}
metachris
reviewed
Feb 19, 2024
| @@ -96,8 +96,8 @@ dockers: | |||
| - --platform=linux/amd64 | |||
| image_templates: | |||
| - "flashbots/suave-geth:{{ .ShortCommit }}-amd64" | |||
| - "flashbots/suave-geth:{{ .Tag }}-amd64" | |||
| - "flashbots/suave-geth:latest-amd64" | |||
| - "flashbots/suave-geth:v{{ .Version }}-amd64" | |||
There was a problem hiding this comment.
also tag it :latest-nightly?
.goreleaser.yaml
Outdated
| - "flashbots/suave-geth:{{ .Tag }}-amd64" | ||
| - "flashbots/suave-geth:latest-amd64" | ||
| - "flashbots/suave-geth:v{{ .Version }}-amd64" | ||
| - "{{ if not .IsNightly }}flashbots/suave-geth:latest-amd64{{ end }}" |
There was a problem hiding this comment.
suggestion:
Suggested change
| - "{{ if not .IsNightly }}flashbots/suave-geth:latest-amd64{{ end }}" | |
| {{- if not .IsNightly }} | |
| - flashbots/suave-geth:latest-amd64 | |
| {{ else }} | |
| - flashbots/suave-geth:latest-nightly-amd64 | |
| {{- end }} |
.goreleaser.yaml
Outdated
| - "flashbots/suave-geth:{{ .Tag }}-arm64" | ||
| - "flashbots/suave-geth:latest-arm64" | ||
| - "flashbots/suave-geth:v{{ .Version }}-arm64" | ||
| - "{{ if not .IsNightly }}flashbots/suave-geth:latest-arm64{{ end }}" |
There was a problem hiding this comment.
suggestion:
Suggested change
| - "{{ if not .IsNightly }}flashbots/suave-geth:latest-arm64{{ end }}" | |
| {{- if not .IsNightly }} | |
| - flashbots/suave-geth:latest-arm64 | |
| {{ else }} | |
| - flashbots/suave-geth:latest-nightly-arm64 | |
| {{- end }} |
.goreleaser.yaml
Outdated
| @@ -123,6 +123,12 @@ docker_manifests: | |||
| - "flashbots/suave-geth:latest-amd64" | |||
There was a problem hiding this comment.
yes, I think this whole block should look like:
{{- if not .IsNightly }}
- name_template: "flashbots/suave-geth:latest"
image_templates:
- "flashbots/suave-geth:latest-amd64"
- "flashbots/suave-geth:latest-arm64"
{{ else }}
- name_template: "flashbots/suave-geth:latest-nightly"
image_templates:
- "flashbots/suave-geth:latest-nightly-amd64"
- "flashbots/suave-geth:latest-nightly-arm64"
{{- end }}
.goreleaser.yaml
Outdated
| @@ -123,6 +123,12 @@ docker_manifests: | |||
| - "flashbots/suave-geth:latest-amd64" | |||
| - "flashbots/suave-geth:latest-arm64" | |||
|
|
|||
| nightly: | |||
| name_template: "{{ incpatch .Version }}-nightly" | |||
| tag_name: nightly | |||
There was a problem hiding this comment.
doubt:
I am not very familiar with this part of goreleaser, but maybe it should be tag_name: latest-nightly.
metachris
reviewed
Feb 19, 2024
.goreleaser.yaml
Outdated
| - "flashbots/suave-geth:{{ .Tag }}-amd64" | ||
| - "flashbots/suave-geth:latest-amd64" | ||
| - "flashbots/suave-geth:v{{ .Version }}-amd64" | ||
| {{- if not .IsNightly }} |
There was a problem hiding this comment.
can you remove this inversion this for less cognitive load? i.e. instead of {{- if not .IsNightly }} do {{- if .IsNightly }}
There was a problem hiding this comment.
😢 but I so love double negations 😢
metachris
approved these changes
Feb 19, 2024
metachris
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR enables nightly releases for
suave-geth.📚 References