Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind suave.dev chain to 0.0.0.0 #156

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Bind suave.dev chain to 0.0.0.0 #156

merged 1 commit into from
Jan 10, 2024

Conversation

ferranbt
Copy link
Collaborator

📝 Summary

This PR binds the http network for the suave development node to 0.0.0.0. Otherwise, when running inside docker, the node is not accessible.

📚 References

  • I have seen and agree to CONTRIBUTING.md

@ferranbt ferranbt mentioned this pull request Jan 10, 2024
Merged
@ferranbt ferranbt merged commit 626a3e5 into main Jan 10, 2024
3 checks passed
@ferranbt ferranbt deleted the fix/suave-dev-bind-public branch January 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarzzz dmarzzz dmarzzz approved these changes

@lthibault lthibault lthibault approved these changes

@Ruteri Ruteri Awaiting requested review from Ruteri Ruteri is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferranbt @lthibault @dmarzzz