Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suave-geth release checklist #155

Merged
merged 2 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/releaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Log tag name
run: echo "Build for tag ${{ github.ref_name }}"

- name: release dry run
- name: Create release
run: make release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion miner/stress/clique/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func makeSealer(genesis *core.Genesis) (*node.Node, *eth.Ethereum, error) {
datadir, _ := os.MkdirTemp("", "")

config := &node.Config{
Name: "geth",
Name: "suave-geth",
Version: params.Version,
DataDir: datadir,
P2P: p2p.Config{
Expand Down
8 changes: 4 additions & 4 deletions params/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ import (
)

const (
VersionMajor = 1 // Major version component of the current release
VersionMinor = 12 // Minor version component of the current release
VersionPatch = 0 // Patch version component of the current release
VersionMeta = "stable" // Version metadata to append to the version string
VersionMajor = 0 // Major version component of the current release
VersionMinor = 1 // Minor version component of the current release
VersionPatch = 1 // Patch version component of the current release
VersionMeta = "dev" // Version metadata to append to the version string
)

// Version holds the textual version string.
Expand Down
39 changes: 39 additions & 0 deletions suave/release-checklist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
suave-geth Release Checklist
============================

Note: the best days to release a new version are Monday to Wednesday. Never release on a Friday (because of the risk of needing to work on the weekend).

### Prepare the release

- [ ] Run linter and tests:
```bash
$ make lint && make test && make suave
$ ./build/bin/suave-geth version
```
- [ ] Test latest version with [suapp-examples](https://github.com/flashbots/suapp-examples) and [suave-std](https://github.com/flashbots/suave-std)

### Update documentation (if needed)

Prepare documentation updates before the release is published. Only if needed.

- [ ] [Docs](https://github.com/flashbots/suave-docs)
- [ ] [Specs](https://github.com/flashbots/suave-specs)

### Publish the release

- [ ] Pick the version (i.e. `v0.2.0-stable`)
- [ ] Update the version number in [`params/version.go`](../params/version.go)
- [ ] Make a commit with the version number change (i.e. `git commit -m 'bump version to v0.2.0'`)
- [ ] Tag new version (`git tag -s v0.2.0`)
- [ ] Push tag to Github. At this point, [CI](https://github.com/flashbots/suave-geth/blob/release-checklist/.github/workflows/releaser.yml) builds the packages, publishes Docker images to [Docker hub](https://hub.docker.com/r/flashbots/suave-geth), and creates a draft release on Github (all using [Goreleaser](https://github.com/flashbots/suave-geth/blob/release-checklist/.goreleaser.yaml))
- [ ] Edit the draft release on Github to prepare nice release notes
- [ ] Publish the release (note: this will send an email to subscribers on Github)

### After publishing

- [ ] Test the Release: Download the release binary: `curl -L https://suaveup.flashbots.net | bash` and check the version with `suave-geth version`
- [ ] Increment the version number to the next patch version and `-dev` meta in [`params/version.go`](../params/version.go) and push a commit

### Announcing

- [ ] Make a forum post, possibly announce on Discord and Twitter
Loading