Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
edit bidcollect.go, bid-processor.go and bidcollector.go to accept the
--redis
falgβ± Motivation and Context
Since PR50, the default behavior of the bid collector is to assume that there's a redis service running, even if we do not add the
--redis
falg.If you run:
You will get this error:
A workaround is to set
--redis-addr ""
π References
β I have run these commands
make lint
make test
go mod tidy
make lint
yields several warnings an errors, non of them seem to be related to this PR