cleanup

flashbots · Jun 13, 2024 · 5d870eb · 5d870eb
1 parent f76ce05
commit 5d870eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/docs/2024-06_bidcollect.md b/docs/2024-06_bidcollect.md
@@ -26,14 +26,14 @@ For every day, there are two CSV files:
 | `received_at_ms`         | When the bid was first received by the relayscan collector | all          |
 | `timestamp_ms`           | When the bid was received by the relay                     | 1 + 2        |
 | `slot`                   | Slot the bid was submitted for                             | all          |
-| `slot_t_ms`              | How late into the slot the bid was received by the relay   | all          |
+| `slot_t_ms`              | How late into the slot the bid was received by the relay   | 1 + 2        |
 | `value`                  | Bid value in wei                                           | all          |
 | `block_hash`             | Block hash                                                 | all          |
 | `parent_hash`            | Parent hash                                                | all          |
-| `block_number`           | Block number                                               | all          |
-| `relay`                  | Relay name                                                 | all          |
 | `builder_pubkey`         | Builder pubkey                                             | 1 + 2        |
+| `block_number`           | Block number                                               | all          |
 | `block_fee_recipient`    | Block fee recipient                                        | 2            |
+| `relay`                  | Relay name                                                 | all          |
 | `proposer_pubkey`        | Proposer pubkey                                            | 1            |
 | `proposer_fee_recipient` | Proposer fee recipient                                     | 1            |
 | `optimistic_submission`  | Optimistic submission flag                                 | 1            |

diff --git a/services/bidcollect/types.go b/services/bidcollect/types.go
@@ -36,7 +36,6 @@ type CommonBid struct {
 	ReceivedAtMs int64 `json:"received_at"`
 
 	// Common fields
-	// Timestamp     int64  `json:"timestamp"`
 	Slot          uint64 `json:"slot"`
 	BlockNumber   uint64 `json:"block_number"`
 	BlockHash     string `json:"block_hash"`
@@ -80,6 +79,7 @@ func (bid *CommonBid) ToCSVFields() []string {
 		bidIntoSlotTmsString = fmt.Sprint(bitIntoSlotTms)
 	}
 
+	// Optimistic string can be (1) empty, (2) `true` or (3) `false`
 	bidIsOptimisticString := ""
 	if bid.SourceType == SourceTypeDataAPI {
 		bidIsOptimisticString = boolToString(bid.OptimisticSubmission)