Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric block_sim_errors always output zero #245

Merged
merged 1 commit into from
Nov 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions crates/rbuilder/src/telemetry/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,7 @@ register_metrics! {
&["relay", "kind"]
)
.unwrap();
pub static BLOCK_SIM_ERRORS: IntCounterVec = IntCounterVec::new(
Opts::new("block_sim_errors", "counter of block simulation errors"),
&[]
)
pub static BLOCK_SIM_ERRORS: IntCounter = IntCounter::new("block_sim_errors", "counter of block simulation errors")
.unwrap();
pub static SIMULATED_OK_ORDERS: IntCounter =
IntCounter::new("simulated_ok_orders", "Simulated succeeded orders").unwrap();
Expand Down Expand Up @@ -246,7 +243,7 @@ pub fn inc_too_many_req_relay_errors(relay: &MevBoostRelayID) {
}

pub fn inc_failed_block_simulations() {
BLOCK_SIM_ERRORS.with_label_values(&[]).inc()
BLOCK_SIM_ERRORS.inc()
}

pub fn set_current_block(block: u64) {
Expand Down
Loading