dont' recover signer in a hot loop #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results for
|
| Date (UTC) | 2024-10-09T11:02:26+00:00 |
| Commit | dce6f799d2634aac35fccd09ea79cdbd32f18782 |
| Base SHA | 66613c9eb68ec0072e5ede5641a53b023ae3d834 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| MEV-Boost SubmitBlock serialization/JSON encoding | -5.68% | Performance has improved. |
ferranbt
approved these changes
Oct 9, 2024
|
@ferranbt I think microbenchmark for commit_tx can catch that. |
astarinmymind
pushed a commit
that referenced
this pull request
Oct 15, 2024
## 📝 Summary This is pretty serious regression that I've missed while reviewing external PR on one of the reth upgrades. We need to be careful to not allow something like that slip in the future. ## 💡 Motivation and Context calling recover_signer verifies transaction signature every time we try to executing something in the vm. --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is pretty serious regression that I've missed while reviewing external PR on one of the reth upgrades.
We need to be careful to not allow something like that slip in the future.
💡 Motivation and Context
calling recover_signer verifies transaction signature every time we try to executing something in the vm.
✅ I have completed the following steps:
make lintmake test