Skip to content

Commit

Permalink
chore(reth-rbuilder): remove unnecesary tracing init (#246)
Browse files Browse the repository at this point in the history
## πŸ“ Summary

Removes the tracing initialization when spawning an `rbuilder` handle.

## πŸ’‘ Motivation and Context

Reth indeed boots up tracing itself, so this is indeed unnecessary.

## βœ… I have completed the following steps:

* [x] Run `make lint`
* [x] Run `make test`
* [ ] Added tests (if applicable)
  • Loading branch information
Evalir authored Nov 14, 2024
1 parent e14ec60 commit 0f9c330
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions crates/reth-rbuilder/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ where
let result = async {
let config: Config = load_config_toml_and_env(config_path)?;

// TODO: Check removing this is OK. It seems reth already sets up the global tracing
// subscriber, so this fails
// config.base_config.setup_tracing_subscriber().expect("Failed to set up rbuilder tracing subscriber");

// Spawn redacted server that is safe for tdx builders to expose
telemetry::servers::redacted::spawn(
config.base_config().redacted_telemetry_server_address(),
Expand Down

0 comments on commit 0f9c330

Please sign in to comment.