[WIP] Adds useful gadgets #56

Ruteri · 2024-08-01T16:45:29Z

Gadgets:

VersionGadget
AttestationGadget
AuthGadget
CensorshipResistanceGadget
EncryptedInputsGadget
KillswitchGadget

WIP - will be adding tests and ironing out bugs

amiller · 2024-08-01T17:29:45Z

src/gadgets/CensorshipResistanceGadget.sol

+        cr_epoch = epoch + 1;
+    }
+
+    // add the following modifiers to your calls to make them censorship resistant


Cool, delighted to see a censorship resistance queue, like Ethereum Alarm Clock but for kettle apps. This looks like a nice way to do it with a modifier. I didn't follow how it works yet though, I was expecting a queue I guess

v5.0.2

MoeMahhouk · 2024-08-02T11:36:42Z

src/gadgets/AuthGadget.sol

+    modifier auth_query(bytes32 role, bytes memory query, bytes memory signature) {
+        require(Secp256k1.verify(msg.sender, keccak256(abi.encodePacked(msg.sender, query)), signature));
+        require(hasRole(role, msg.sender));
+        _;


I am not sure what the purpose of this modifier but it can use the auth modifier internally since it is doing the same check there too.

Suggested change

modifier auth_query(bytes32 role, bytes memory query, bytes memory signature) {

require(Secp256k1.verify(msg.sender, keccak256(abi.encodePacked(msg.sender, query)), signature));

require(hasRole(role, msg.sender));

_;

modifier auth_query(bytes32 role, bytes memory query, bytes memory signature) {

auth(role);

require(Secp256k1.verify(msg.sender, keccak256(abi.encodePacked(msg.sender, query)), signature));

_;

MoeMahhouk · 2024-08-02T11:41:35Z

src/gadgets/AuthGadget.sol

+    function auth_query_hash(bytes32 role, bytes memory query) public returns (bytes32) {
+        require(hasRole(role, msg.sender));
+        return keccak256(abi.encodePacked(msg.sender, query));
+    }


can you use the auth modifier from above here too?

Suggested change

function auth_query_hash(bytes32 role, bytes memory query) public returns (bytes32) {

require(hasRole(role, msg.sender));

return keccak256(abi.encodePacked(msg.sender, query));

}

function auth_query_hash(bytes32 role, bytes memory query) public auth(role) returns (bytes32) {

return keccak256(abi.encodePacked(msg.sender, query));

}

MoeMahhouk · 2024-08-02T11:47:11Z

src/gadgets/CensorshipResistanceGadget.sol

+import {IAndromeda} from "src/IAndromeda.sol";
+
+abstract contract CensorshipResistanceGadget is AttestationGadget {
+    function Suave() internal virtual returns (IAndromeda);


What's the purpose of this function?

To force the contract using the CRgadget to have IAndromeda instance as part of it?

MoeMahhouk · 2024-08-02T11:49:39Z

src/gadgets/CensorshipResistanceGadget.sol

+    mapping(bytes32 => bool) private cr_challenges;
+
+    function offchain_restart_challenge() public returns (bytes32 challenge, bytes memory attestation) {
+        require(!cr_challenges[challenge]); /* already challenged */


this check seems off a bit.
It is checking if the returned challenge was already done but it has not been set yet. So this require will always pass because challenge at this point is still empty and not set. right? or Did I oversee something?

MoeMahhouk · 2024-08-02T13:36:05Z

src/gadgets/CensorshipResistanceGadget.sol

+            challenge = Suave().localRandom();
+            _set_local_challenge(challenge);


I know the probability is very low but here the randomly generated challenge might collide with a previously generated one from before. So probably there should be a check here before setting the new local challenge.
Or do you need to generate a one shot challenge?

Suggested change

challenge = Suave().localRandom();

_set_local_challenge(challenge);

challenge = Suave().localRandom();

while(cr_challenges[challenge]) {

challenge = Suave().localRandom();

}

_set_local_challenge(challenge);

src/gadgets/CensorshipResistanceGadget.sol

MoeMahhouk · 2024-08-02T14:30:08Z

src/gadgets/CensorshipResistanceGadget.sol

+    modifier force_cr(uint256 epoch) {
+        /* IMPORTANT! This is set regardless of revert status */
+        require(cr_challenges[_get_local_challenge()]);
+        require(epoch >= cr_epoch); // resubmission, ignore - user's view is outdated
+        uint256 c_local_epoch = _get_local_epoch();
+        if (epoch > c_local_epoch) {
+            // user requested epoch higher than kettle's local view - this means noone else did so before (can be benign)
+            _set_local_epoch(epoch); // refuse to serve anything less than epoch in subsequent calls
+            c_local_epoch = epoch; // use max(local, epoch) in the rest of the function
+        }
+        require(cr_epoch >= c_local_epoch); // local view of the chain must be at least until local epoch - otherwise the chain is being censored
+        require(cr_epoch == epoch); // and request and chain epochs must match - otherwise we are getting spoofed
+        _;


I am confused and not sure what to get out of this.
Could you please elaborate more on what this is potentially doing?
I can't see how this is censorship resistant and can you give me an example of a censorship case here where this would be prevented by this modifier?

MoeMahhouk · 2024-08-02T14:41:51Z

src/gadgets/VersionGadget.sol

+
+    function all_versions() public returns (bytes32[] memory) { /* TODO */ }
+    /* TODO: allow using past versions, maybe */


Since sets data structure are not there by default, we can achieve this by using mapping and arrays.
Here is a minimal suggestion

Suggested change

function all_versions() public returns (bytes32[] memory) { /* TODO */ }

/* TODO: allow using past versions, maybe */

bytes32[] private versions;

mapping(bytes32 => bool) private versionExists;

// Adds the current version to the version history if it doesn't already exist

function add_current_version() public {

bytes32 version = current_version();

if (!versionExists[version]) {

versions.push(version);

versionExists[version] = true;

}

}

// Returns an array of all recorded versions

function all_versions() public view returns (bytes32[] memory) {

return versions;

}

MoeMahhouk · 2024-08-02T14:44:04Z

src/gadgets/EncryptedInputsGadget.sol

+abstract contract EncryptedInputsGadget is VersionGadget, AttestationGadget, CensorshipResistanceGadget {
+    function km() internal pure virtual returns (KeyManager);
+
+    bytes private constant input_enc_derivation_path_prefix = "m/1'";


small nit

Suggested change

bytes private constant input_enc_derivation_path_prefix = "m/1'";

bytes private constant INPUT_ENC_DERIVATION_PATH_PREFIX = "m/1'";

…fore onchain challenge is required

Adds gadgets useful to secrets manager

86514ea

Ruteri changed the title ~~Adds useful gadgets - censorship resistance, inputs and outputs encryption, versioning, authentication and authorization~~ [WIP] Adds useful gadgets Aug 1, 2024

amiller reviewed Aug 1, 2024

View reviewed changes

Ruteri added 2 commits August 2, 2024 13:12

Adds missing gitignore file

a405158

forge install: openzeppelin-contracts

5574cd5

v5.0.2

MoeMahhouk reviewed Aug 2, 2024

View reviewed changes

src/gadgets/CensorshipResistanceGadget.sol Show resolved Hide resolved

MoeMahhouk reviewed Aug 2, 2024

View reviewed changes

Ruteri added 5 commits August 2, 2024 19:30

Adds tests for remaining gadgets

b6e8aec

Adds a hard limit on how many offchain calls a contract will allow be…

7cc048e

…fore onchain challenge is required

Randomize andromeda host between racing tests

ee263e6

Formats gadgets

b1707b0

Renames Suave() to andromeda(), scopes local variables

77bac53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Adds useful gadgets #56

[WIP] Adds useful gadgets #56

Ruteri commented Aug 1, 2024 •

edited

Loading

amiller Aug 1, 2024

MoeMahhouk Aug 2, 2024

MoeMahhouk Aug 2, 2024

MoeMahhouk Aug 2, 2024

MoeMahhouk Aug 2, 2024

MoeMahhouk Aug 2, 2024

MoeMahhouk Aug 2, 2024

MoeMahhouk Aug 2, 2024

MoeMahhouk Aug 2, 2024

		challenge = Suave().localRandom();
		_set_local_challenge(challenge);


		function all_versions() public returns (bytes32[] memory) { /* TODO */ }
		/* TODO: allow using past versions, maybe */

-    function all_versions() public returns (bytes32[] memory) { /* TODO */ }
-    /* TODO: allow using past versions, maybe */
+    bytes32[] private versions;
+    mapping(bytes32 => bool) private versionExists;
+    // Adds the current version to the version history if it doesn't already exist
+    function add_current_version() public {
+        bytes32 version = current_version();
+        if (!versionExists[version]) {
+            versions.push(version);
+            versionExists[version] = true;
+        }
+    }
+    // Returns an array of all recorded versions
+    function all_versions() public view returns (bytes32[] memory) {
+        return versions;
+    }

	bytes private constant input_enc_derivation_path_prefix = "m/1'";
	bytes private constant INPUT_ENC_DERIVATION_PATH_PREFIX = "m/1'";

[WIP] Adds useful gadgets #56

Are you sure you want to change the base?

[WIP] Adds useful gadgets #56

Conversation

Ruteri commented Aug 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ruteri commented Aug 1, 2024 •

edited

Loading