Fix Rocket decompression and make this compile with Visual Studio 2019. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't accounting for the output size in the header, causing it to produce garbage data after the end of the decompressed data by processing the unused descriptor bits in the last field that it read.
...this project is C++14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the copy of this in the shell extension. It compiles fine with MSYS2, but Visual Studio gets caught on some mistakes. This fixes them to get it working.
The Rocket decompression wasn't stopping at the last decompressed byte, advancing on until it exhausted all of the descriptor bits, causing garbage bytes to be produced past the end of the decompressed data.