Bug/date not recognized #54
Conversation
| cast(extract(year from current_date) as {{ dbt.type_string() }}) as current_year, | ||
| cast(extract(year from {{ dbt.dateadd('year', -1, 'current_date') }}) as {{ dbt.type_string() }}) as last_year |
There was a problem hiding this comment.
I moved this up here just to make it a little easier to follow.
| case when cast({{ dbt.dateadd('day', -1, "cast(current_year || '-03-01' as date)") }} as date) >= current_date | ||
| then cast({{ dbt.dateadd('day', -1, "cast(current_year || '-03-01' as date)") }} as date) | ||
| else cast({{ dbt.dateadd('day', -1, "cast(last_year || '-03-01' as date)") }} as date) |
There was a problem hiding this comment.
In this case I found it was easiest to go a day back from March to get the last day in Feb.
| end as current_year_end_date, | ||
| source_relation | ||
| source_relation, | ||
| case when financial_year_end_month = 2 and financial_year_end_day = 29 |
There was a problem hiding this comment.
Moving this condition first appears to prevent the warehouse from trying to execute the other nested conditions that cause the error.
| ), year_end as ( | ||
|
|
||
| -- Calculate the current financial year-end date for each organization: | ||
| -- For February, determine last day by subtracting 1 day from March 1, avoiding leap year logic. |
integration_tests/tests/.gitkeep
Outdated
There was a problem hiding this comment.
Is this a necessary file? If not, can we remove it.
There was a problem hiding this comment.
Nope--removed!
Feature: Add Quickstart Model Counts to README
There was a problem hiding this comment.
Additionally, I noticed that fields like account_class or source_type have all-caps values... should we do the same with account_name ? (Not really an issue, more of a standardization thing) . I can make an feature flag if it's significant enough cc @fivetran-joemarkiewicz
There was a problem hiding this comment.
Per conversation with @fivetran-joemarkiewicz, this is the source behavior, so we'll keep as is.
|
@fivetran-reneeli That's the only place |
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
I was able to recreate the error using seed data:
Error is resolved with updates.
Consistency tests passed using internal data. I could not use seed data for this test because of the error, but I wanted to make sure no changes occurred after the update.
Tested the update to
current_year_end_datefor when the previous fiscal year end falls in the same calendar year as but before today’s date.