Merge pull request #8 from fivetran/bugix/account-deletes-removal

Bugix/account deletes removal
fivetran · May 19, 2022 · 9c9b62a · 9c9b62a
2 parents 1a42b0d + 5e8a0db
commit 9c9b62a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# dbt_sage_intacct_source v0.1.2
+
+## Updates
+- Removed the `_fivetran_deleted` filter in the `stg_sage_intacct__gl_account`. We saw there were records in the `gl_detail` table that were associated with accounts that were deleted, which affected our joins and bubbled up later in the final P&L and balance sheet models. By removing the filter the balances tie out. However, we've kept `_fivetran_deleted` as a column so the user may filter that out on their own.
+([#8](https://github.com/fivetran/dbt_sage_intacct_source/pull/8))
+
 # dbt_sage_intacct_source v0.1.1
 
 ## Updates

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'sage_intacct_source'
-version: '0.1.1'
+version: '0.1.2'
 config-version: 2
 require-dbt-version: [">=1.0.0", "<2.0.0"]
 

diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,6 +1,6 @@
 
 name: 'sage_intacct_source_integration_tests'
-version: '0.1.1'
+version: '0.1.2'
 config-version: 2
 
 profile: 'integration_tests' 

diff --git a/models/stg_sage_intacct__gl_account.sql b/models/stg_sage_intacct__gl_account.sql
@@ -59,5 +59,5 @@ final as (
     from fields
 )
 
-select * from final
-where not coalesce(_fivetran_deleted, false)
+select * 
+from final