Skip to content

Commit

Permalink
Release review, regen docs
Browse files Browse the repository at this point in the history
  • Loading branch information
fivetran-avinash committed Aug 1, 2024
1 parent 09d4a0f commit a96fe4d
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
## 🚨 Breaking Changes: Bug Fixes 🚨
- Updated the structure of the `int_sage_intacct__general_ledger_date_spine` model for improved performance and maintainability.
- Modified the date spine logic so that the model will take the maximum `entry_date_at` from the `sage_intacct__general_ledger` for the last date of the spine if it is available, rather than the current date. This will help capture future-dated transactions as well beyond the current date.
- This is a breaking change, as this will change what transaction records of `sage_intacct__general_ledger_by_period` end up in our final models.
- This is a breaking change, as changing the behavior of the date spine which will adjust the transaction records in the `sage_intacct__general_ledger_by_period` model to be more accurate.

# Bug Fixes
- Updated the `int_sage_intacct__general_ledger_date_spine` model to accommodate for the cases when the compiled `sage_intacct__general_ledger` model has no transactions. In this case, the model now defaults to a range of one month leading up to the current date.
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ vars:
sage_intacct_ap_bill_item_identifier: "sage_intacct__ap_bill_item"
sage_intacct_ar_invoice_identifier: "sage_intacct__ar_invoice"
sage_intacct_ar_invoice_item_identifier: "sage_intacct__ar_invoice_item"
sage_intacct_schema: sage_intacct_integration_tests_6
sage_intacct_schema: sage_intacct_integration_tests_5

# For validation testing. To be commented out before release.
# sage_intacct_database: <insert database>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@
-- this test is to make sure there is no fanout between the spine and the general_ledger_by_period

with spine as (

select count(*) as spine_count
from {{ target.schema }}_sage_intacct_dev.int_sage_intacct__general_ledger_date_spine
from {{ ref('int_sage_intacct__general_ledger_date_spine') }}
),

general_ledger_by_period as (

select count(*) as glp_count
from {{ target.schema }}_sage_intacct_dev.sage_intacct__general_ledger_by_period
from {{ ref('sage_intacct__general_ledger_by_period') }}
)

-- test will return values and fail if the row counts don't match
Expand Down

0 comments on commit a96fe4d

Please sign in to comment.