Feature/department id casting

[fivetran-joemarkiewicz]

PR Overview

This PR will address the following Issue/Feature: This is a complimentary PR to the dbt_quickbooks PR#82 that adds the department_id to the GL model.

This PR will result in the following new package version: v0.8.0

Although this is not a breaking change, it will be batched with other breaking changes.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

This PR includes string type casting for the department_id in the relevant header and line item tables.

• stg_quickbooks__bill
• stg_quickbooks__bill_payment
• stg_quickbooks__credit_memo
• stg_quickbooks__department
• stg_quickbooks__deposit
• stg_quickbooks__invoice
• stg_quickbooks__journal_entry_line
• stg_quickbooks__purchase
• stg_quickbooks__refund_receipt
• stg_quickbooks__sales_receipt
• stg_quickbooks__vendor_credit

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• dbt run –vars (if applicable)

Before marking this PR as “ready for review” the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as “ready for review”:

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

This is a pretty straight forward update where the department_id fields are casted in the relevant staging models in order to ensure the unioning of the fields downstream are successful. This casting is particularly necessary for tables that have all null values as the datatype cannot always be inferred. Therefore, the casting is necessary to ensure success.

Additionally, it was confirmed that all relevant macros have the department_id and set to datatype string. Therefore we can be comfortable that the field will be included regardless.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• README updates have been applied (if applicable)
• DECISIONLOG updates have been updated (if applicable)
• Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🧵

[fivetran-avinash]

@fivetran-joemarkiewicz I noticed that the seed files had mostly null department ids so I tried and tested with and without a department id to make sure everything looked good (passed both on the source and transform so all looks good there).

Only one significant comment to address and you should be good to go!

[fivetran-joemarkiewicz]

Thanks for the review @fivetran-avinash! Applied the changes and all is ready for re-review!

[fivetran-avinash]

Time to merge!