Skip to content

Commit

Permalink
PR fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
fivetran-avinash committed Dec 19, 2024
1 parent 04796cf commit b5a5f3a
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
## Bug Fix
- Updated the logic in `int_quickbooks__retained_earnings` to ensure accounting periods with no revenue and expense class lines were accounted for.
- This will ensure the net income adjustment is available regardless of existing revenue or expenses.
- Brought in `created_at` and `updated_at` fields for the `credit_card_pymt` and `invoice` intermediate `*_double_entry` models to provide full support for the [`v0.17.0` release update](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0).

# dbt_quickbooks v0.17.0
[PR #146](https://github.com/fivetran/dbt_quickbooks/pull/146) introduces the following updates:
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ final as (
cast(bank_account_id as {{ dbt.type_string() }}) as account_id,
class_id,
department_id,
created_at,
updated_at,
'credit' as transaction_type,
'credit card payment' as transaction_source
from credit_card_payment_prep
Expand All @@ -65,6 +67,8 @@ final as (
cast(credit_card_account_id as {{ dbt.type_string() }}) as account_id,
class_id,
department_id,
created_at,
updated_at,
'debit' as transaction_type,
'credit card payment' as transaction_source
from credit_card_payment_prep
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ final as (
account_id,
class_id,
department_id,
created_at,
updated_at,
case when invoice_line_transaction_type = 'DiscountLineDetail' then 'debit'
else 'credit'
end as transaction_type,
Expand All @@ -197,6 +199,8 @@ final as (
ar_accounts.account_id,
class_id,
department_id,
created_at,
updated_at,
case when invoice_line_transaction_type = 'DiscountLineDetail' then 'credit'
else 'debit'
end as transaction_type,
Expand Down

0 comments on commit b5a5f3a

Please sign in to comment.