Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI config #91

Open
wants to merge 3 commits into
base: lion_484_templates_support_ci_test_pre
Choose a base branch
from
Open

Update CI config #91

wants to merge 3 commits into from

Conversation

omrilotan
Copy link
Member

@omrilotan omrilotan commented Aug 30, 2023 •
edited
Loading

  1. Use a matrix to run the same step with multiple images
  2. Use the new cimg images instead of the deprecated "circleci" (EOL 2 years ago with node 17)
  3. Improved use of cache layer and workspace persistence

@omrilotan omrilotan force-pushed the lion_484_templates_support_ci_test_pre-ci_update branch from 9006588 to fab705e Compare August 30, 2023 09:08
@omrilotan omrilotan marked this pull request as ready for review August 30, 2023 09:14
@omrilotan omrilotan requested a review from a team as a code owner August 30, 2023 09:14
raphaelboukara
raphaelboukara reviewed Aug 31, 2023
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml
- persist_to_workspace:
root: .
paths:
- ./node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you persist node_modules to workspace I suppose you don't need to save it to cache anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache persists between runs and makes it quicker to run the next commit

@omrilotan
Copy link
Member Author

Updated the PR's description to reflect the latest changes

@omrilotan
Copy link
Member Author

@raxyz Feel free to merge if you want this change. It will merge onto #90

@odeadglaz odeadglaz mentioned this pull request Sep 12, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelboukara raphaelboukara raphaelboukara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omrilotan @raphaelboukara