Added redirection check for administrator and site owner roles. #351
+35
−2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| use Drupal\Core\Entity\EntityTypeManagerInterface; | ||
| use Drupal\openy_gc_auth\Event\GCUserLoginEvent; | ||
| use Symfony\Component\EventDispatcher\EventDispatcherInterface; | ||
| use Symfony\Component\HttpFoundation\RedirectResponse; | ||
|
|
||
| /** | ||
| * User Authorizer class. | ||
|
|
@@ -72,11 +73,22 @@ public function authorizeUser($name, $email, array $extra_data = []) { | |
| $account->save(); | ||
| } | ||
| } | ||
| // List of roles to redirect user login page. | ||
| $userRolesArray = [ | ||
| 'administrator', | ||
| 'virtual_ymca_editor', | ||
| ]; | ||
| // Redirecting user login page. | ||
| foreach ($userRolesArray as $role) { | ||
| if ($account->hasRole($role)) { | ||
| $response = new RedirectResponse('/user/login', 301); | ||
| $response->send(); | ||
|
There was a problem hiding this comment. It is better to add Drupal message which is saying that you have to login as real user, sin you are an administrator. There was a problem hiding this comment. @anpolimus I have added Drupal message, Can you please review. |
||
| } | ||
| } | ||
| // Instantiate GC login user event. | ||
| $event = new GCUserLoginEvent($account, $extra_data); | ||
| // Dispatch the event. | ||
| $this->eventDispatcher->dispatch(GCUserLoginEvent::EVENT_NAME, $event); | ||
| user_login_finalize($account); | ||
|
|
||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add this code above:
$loginUrl = Url::fromRoute('user.login');and replace this line:
It will be a more stable approach. I had many projects in the past when we were renaming user login/register routes to avoid spam bots attacks. In your case, it is hard-coded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anpolimus I have updated the code as per you suggestion, Can you please review.