Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add target: wasm #17

Merged
merged 1 commit into from
Oct 4, 2024
Merged

add target: wasm #17

merged 1 commit into from
Oct 4, 2024

Conversation

oligamiq
Copy link
Contributor

@oligamiq oligamiq commented Oct 3, 2024

No description provided.

@oligamiq oligamiq mentioned this pull request Oct 3, 2024
Copy link
Owner

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines 31 to 34
- name: Install `cargo wasi`
run: cargo install cargo-wasi
- name: Install `wasmtime`
run: curl https://wasmtime.dev/install.sh -sSf | bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to be failing. Could you also move this out into a new, dedicated job, instead of making every matrix job run the wasm tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.
addition source ~/.bashrc.
cargo-wasi bin support only linux.

@oligamiq
Copy link
Contributor Author

oligamiq commented Oct 4, 2024

I updated commit

Copy link
Owner

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen
Copy link
Owner

fitzgen commented Oct 4, 2024

Hmm looks like CI is still failing. I think that $PATH is not preserved across CI steps unless you explicitly add something: https://stackoverflow.com/questions/77931676/how-to-add-a-directory-to-path-variable-in-github-actions

@oligamiq
Copy link
Contributor Author

oligamiq commented Oct 4, 2024

oh, thanks. and I forget to rm test on matrix

@oligamiq
Copy link
Contributor Author

oligamiq commented Oct 4, 2024

Sorry. I accidentally closed it once by mistake, I've checked the operation using act, so it should be fine.

@fitzgen fitzgen merged commit a927d86 into fitzgen:main Oct 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants