Fix wallet scanning for newly created wallet #1508

levoncrypto · 2024-12-16T07:54:43Z

No description provided.

coderabbitai · 2024-12-16T07:54:52Z

Walkthrough

The pull request introduces several modifications to the wallet initialization and recovery processes in the application. A new -newwallet boolean argument has been added to enhance control during wallet creation and scanning. Changes include improvements to error handling, adjustments to the shutdown process, and optimizations in wallet transaction scanning, particularly for newly created wallets. These updates aim to streamline the workflow and ensure proper interactions between wallet-related parameters.

Changes

File	Change Summary
`src/init.cpp`	Added `-newwallet` boolean argument (default: false) for wallet scanning; enhanced error handling and shutdown processes.
`src/qt/recover.cpp`	Modified `askRecover` function to set `-newwallet` to true when not recovering an existing wallet.
`src/wallet/wallet.cpp`	Updated `ScanForWalletTransactions` to skip scanning for newly created wallets; adjusted logging accordingly.

Poem

🐰 A Rabbit's Wallet Tale 🐰

With -newwallet flags unfurled,
Our code dances in a digital world.
No more rescans that drag and wait,
Swift creation is now our fate!
A bunny's wallet, lean and bright ✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60f9ac1 and 4dfdb1a.

📒 Files selected for processing (1)

src/wallet/wallet.cpp (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/wallet/wallet.cpp

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/init.cpp (1)

948-950: Fix typo in comment: 'scaning' should be 'scanning'.

Please correct the spelling in the comment for clarity.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6da96d8 and 6310a38.

📒 Files selected for processing (3)

src/init.cpp (1 hunks)
src/qt/recover.cpp (1 hunks)
src/wallet/wallet.cpp (2 hunks)

✅ Files skipped from review due to trivial changes (1)

src/wallet/wallet.cpp

src/qt/recover.cpp

src/wallet/wallet.cpp

gevorgvoskanyan · 2024-12-24T11:30:08Z

src/wallet/wallet.cpp

+        if (!(GetBoolArg("-newwallet", false))) {uiInterface.InitMessage(_("Rescanning..."));}
        nStart = GetTimeMillis();
        walletInstance->ScanForWalletTransactions(pindexRescan, true, fRecoverMnemonic);
-        LogPrintf(" rescan      %15dms\n", GetTimeMillis() - nStart);
+        if (!(GetBoolArg("-newwallet", false))) {LogPrintf(" rescan      %15dms\n", GetTimeMillis() - nStart);}


What's the reason for making the messages conditional but not the actual operation itself?

The condition to prevent scanning if a new wallet has been created is placed inside the ScanForWalletTransactions function. This approach makes it easy to change the algorithm in the future without having to edit each function call. It also helps avoid code duplication and simplifies testing since all the logic is in one place.

gevorgvoskanyan · 2024-12-26T11:50:19Z

src/wallet/wallet.cpp

+        if (!(GetBoolArg("-newwallet", false))) {uiInterface.InitMessage(_("Rescanning..."));}
        nStart = GetTimeMillis();
        walletInstance->ScanForWalletTransactions(pindexRescan, true, fRecoverMnemonic);
-        LogPrintf(" rescan      %15dms\n", GetTimeMillis() - nStart);
+        if (!(GetBoolArg("-newwallet", false))) {LogPrintf(" rescan      %15dms\n", GetTimeMillis() - nStart);}


Fix wallet scanning for newly created wallet

6310a38

coderabbitai bot reviewed Dec 16, 2024

View reviewed changes

src/qt/recover.cpp Outdated Show resolved Hide resolved

Accept coderabbitai advice

60f9ac1

reubenyap assigned gevorgvoskanyan, psolstice and levonpetrosyan93 Dec 23, 2024

reubenyap requested review from gevorgvoskanyan, psolstice and levonpetrosyan93 December 23, 2024 16:06

gevorgvoskanyan reviewed Dec 24, 2024

View reviewed changes

Minor fix debug message

4dfdb1a

gevorgvoskanyan approved these changes Dec 26, 2024

View reviewed changes

levonpetrosyan93 approved these changes Jan 13, 2025

View reviewed changes

levonpetrosyan93 merged commit df530ba into master Jan 13, 2025
11 checks passed

levonpetrosyan93 deleted the scan_with_wallet_creation branch January 13, 2025 10:34

justanwar mentioned this pull request Jan 13, 2025

Creating (not restoring) wallet with seed should not scan from default wallet birthday #1506

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wallet scanning for newly created wallet #1508

Fix wallet scanning for newly created wallet #1508

levoncrypto commented Dec 16, 2024

coderabbitai bot commented Dec 16, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

gevorgvoskanyan Dec 24, 2024

levoncrypto Dec 24, 2024

gevorgvoskanyan Dec 26, 2024

gevorgvoskanyan Dec 26, 2024

Fix wallet scanning for newly created wallet #1508

Fix wallet scanning for newly created wallet #1508

Conversation

levoncrypto commented Dec 16, 2024

coderabbitai bot commented Dec 16, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

gevorgvoskanyan Dec 24, 2024

Choose a reason for hiding this comment

levoncrypto Dec 24, 2024

Choose a reason for hiding this comment

gevorgvoskanyan Dec 26, 2024

Choose a reason for hiding this comment

gevorgvoskanyan Dec 26, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Dec 16, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)