-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate credentials to use google-auth-library #2466
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! Left one comment.
); | ||
return { | ||
...credentials, | ||
access_token: accessToken, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to assign access_token
here?
I submitted a fix for ADC not working for human accounts here #2553 |
Could you please provide an update on the status of this PR? |
@lahirumaramba @hsubox76 Hello there, as a |
google-auth-library
Resolves: #1377