Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_ui_auth): add autofocus property to PhoneInput widget #334

Merged
merged 4 commits into from
May 14, 2024

Conversation

orenagiv
Copy link
Contributor

Description

When using the PhoneInput widget as described in the "Using widget" or "Building a custom widget" sections here, it usually means there are additional fields or other widgets on screen, and therefore the autofocus: true which is currently hard-coded into the PhoneInput widget might conflict with the desired UX of that screen.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
    Note: I see errors in firebase_ui_firestore (which also exist in the main branch), but no issues in the package which this PR relates to (firebase_ui_auth).
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley
Copy link
Member

Hey @orenagiv - thank you for the PR, could you create a small example app demonstrating this use case, please?

@russellwheatley russellwheatley added auth blocked: customer response Waiting for customer response, e.g. more information was requested. labels Apr 24, 2024
@orenagiv
Copy link
Contributor Author

Hey @russellwheatley
Sure - will send an example ASAP.

@orenagiv
Copy link
Contributor Author

orenagiv commented Apr 29, 2024

Hey @russellwheatley,

The example app can be found here:
https://github.com/orenagiv/firebase_ui_auth_example

You can use the following phone number and verification code to test the flow:

Test phone number: +1 650-555-1234
Verification code: 123456

The relevant Widget which demonstrates the usage of the Firebase UI Auth flow is:

widgets/sign_in_with_mobile.dart

Please let me know if you need anything else.

@russellwheatley
Copy link
Member

@orenagiv - thank you! I'll take a look at some point this week👌

@russellwheatley russellwheatley merged commit eb9e2bd into firebase:main May 14, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth blocked: customer response Waiting for customer response, e.g. more information was requested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants