Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Russell Wheatley <[email protected]>
  • Loading branch information
lesnitsky and russellwheatley authored Sep 1, 2023
1 parent 2a9b4bb commit 7c231c5
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions packages/firebase_ui_storage/doc/grid-view.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

When loading large amounts of objects from Firebase Storage, it makes sense to load them in batches, but requires handling of the pagination logic.

`StorageGridView` implements pagination logic for you, and allows to load objects from the Firebase Storage in batches while scrolling.
`StorageGridView` implements pagination logic for you, and allows to load objects from Firebase Storage in batches while scrolling.

## Usage

Expand Down Expand Up @@ -39,7 +39,7 @@ StorageGridView(

### Custom inital page loading state

When the first page of objects is loading, `StorageGridView` will show a `CircularProgressIndicator` under `MaterialApp` and `CupertinoActivityIndicator` under `CupertinoApp`.
When the first page of objects is loading, `StorageGridView` will show a `CircularProgressIndicator` under `MaterialApp`, and `CupertinoActivityIndicator` under `CupertinoApp`.

You can pass `loadingBuilder` to customize the loading state:

Expand Down Expand Up @@ -79,7 +79,7 @@ StorageGridView(

### Custom scroll views with pagination logic

If you need something more customizable, but stil have pagination logic handled for you, you can use
If you need something more customizable, but still want pagination logic handled for you, you can use
[`PaginatedLoadingController`](https://github.com/firebase/FirebaseUI-Flutter/tree/main/packages/firebase_ui_storage/doc/paginated-loading-controller.md)

---
Expand Down
6 changes: 3 additions & 3 deletions packages/firebase_ui_storage/doc/list-view.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

When loading large amounts of objects from the Firebase Storage, it makes sense to load them in batches, but requires handling of the pagination logic.

`StorageListView` implements pagination logic for you, and allows to load objects from the Firebase Storage in batches while scrolling.
`StorageListView` implements pagination logic for you, and allows to load objects from Firebase Storage in batches while scrolling.

## Usage

Expand All @@ -20,7 +20,7 @@ StorageListView(

### Custom inital page loading state

When the first page of objects is loading, `StorageListView` will show a `CircularProgressIndicator` under `MaterialApp` and `CupertinoActivityIndicator` under `CupertinoApp`.
When the first page of objects is loading, `StorageListView` will show a `CircularProgressIndicator` under `MaterialApp`, and `CupertinoActivityIndicator` under `CupertinoApp`.

You can pass `loadingBuilder` to customize the loading state:

Expand Down Expand Up @@ -60,7 +60,7 @@ StorageListView(

### Custom scroll views with pagination logic

If you need something more customizable, but stil have pagination logic handled for you, you can use
If you need something more customizable, but still want pagination logic handled for you, you can use
[`PaginatedLoadingController`](https://github.com/firebase/FirebaseUI-Flutter/tree/main/packages/firebase_ui_storage/doc/paginated-loading-controller.md)

---
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# PaginatedLoadingController

When loading large amounts of objects from the Firebase Storage, it makes sense to load them in batches, but requires handling of the pagination logic.
When loading large amounts of objects from Firebase Storage, it makes sense to load them in batches, but requires handling of the pagination logic.

Firebase UI Storage provides [`StorageListView`] and [`StorageGridView`] widgets that implement pagination logic for you, and allow to load objects from the Firebase Storage in batches while scrolling.
Firebase UI Storage provides [`StorageListView`] and [`StorageGridView`] widgets that implement pagination logic for you, and allows objects to be loaded from Firebase Storage in batches while scrolling.

In cases where you want to build a completely custom scroll view, but still have pagination logic handled – you can use `PaginatedLoadingController`.

Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_ui_storage/doc/storage-image.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# StorageImage

A widget that loads and displays an image from the Firebase Storage.
A widget that loads and displays an image from Firebase Storage.

## Usage

Expand Down Expand Up @@ -38,7 +38,7 @@ StorageImage(

### Loading indicator

Loading indicator placeholder will show a `CircularProgressIndicator` under `MaterialApp` and `CupertinoActivityIndicator` under `CupertinoApp`.
Loading indicator placeholder will show a `CircularProgressIndicator` under `MaterialApp`, and `CupertinoActivityIndicator` under `CupertinoApp`.

You can customize `size`, `color` and `strokeWidth` of the loading indicator:

Expand Down

0 comments on commit 7c231c5

Please sign in to comment.