-
Notifications
You must be signed in to change notification settings - Fork 68
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* PLAT-9069: Handle null for bad data structure to getMentions * PLAT-9069: Add unittest for getMentions function Co-authored-by: Hong-Duong Le <[email protected]>
- Loading branch information
1 parent
d4e1609
commit 041af0d
Showing
2 changed files
with
80 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
package utils; | ||
|
||
import model.InboundMessage; | ||
import org.junit.BeforeClass; | ||
import org.junit.Test; | ||
|
||
import static org.junit.Assert.*; | ||
import java.util.List; | ||
|
||
|
||
public class SymMessageParserTest { | ||
|
||
private static InboundMessage mMessage; | ||
private static List<Long> mentions; | ||
|
||
@BeforeClass | ||
public static void setUp() { | ||
mMessage = new InboundMessage(); | ||
} | ||
|
||
@Test | ||
public void testNormalGetMentions() { | ||
mMessage.setData("{\"0\":{\"id\":[{\"type\":\"com.symphony.user.userId\",\"value\":\"12987981103609\"}],\"type\":\"com.symphony.user.mention\"}}"); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 1); | ||
assertEquals(mentions.get(0).longValue(), 12987981103609L); | ||
mMessage.setData("{\"0\":{\"id\":[{\"type\":\"com.symphony.user.userId\",\"value\":\"12987981103609\"}],\"type\":\"com.symphony.user.mention\"}," | ||
+ "\"1\":{\"id\":[{\"type\":\"com.symphony.user.userId\",\"value\":\"12987981103610\"}],\"type\":\"com.symphony.user.mention\"}}"); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 2); | ||
assertEquals(mentions.get(0).longValue(), 12987981103609L); | ||
assertEquals(mentions.get(1).longValue(), 12987981103610L); | ||
} | ||
|
||
@Test | ||
public void testGetMentionsEmptyData() { | ||
mMessage.setData(""); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 0); | ||
} | ||
|
||
@Test | ||
public void testGetMentionsNullData() { | ||
mMessage.setData(null); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 0); | ||
} | ||
|
||
@Test | ||
public void testGetMentionsBadFormatData() { | ||
mMessage.setData("{\"0\":{\"id\":[{\"bad-key-type\":\"com.symphony.user.userId\",\"value\":\"12987981103609\"}],\"type\":\"com.symphony.user.mention\"}}"); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 0); | ||
mMessage.setData("{\"0\":{\"id\":[{\"type\":\"com.symphony.user.userId\",\"bad-key-value\":\"12987981103609\"}],\"type\":\"com.symphony.user.mention\"}}"); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 0); | ||
mMessage.setData("{\"0\":{\"id\":[{\"bad-key-type\":\"com.symphony.user.userId\",\"value\":\"12987981103609\"}],\"type\":\"com.symphony.user.mention\"}," | ||
+ "\"1\":{\"id\":[{\"type\":\"com.symphony.user.userId\",\"value\":\"12987981103610\"}],\"type\":\"com.symphony.user.mention\"}}"); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 1); | ||
assertEquals(mentions.get(0).longValue(), 12987981103610L); | ||
} | ||
|
||
@Test | ||
public void testGetMentionsUnmatchedType() { | ||
mMessage.setData("{\"0\":{\"id\":[{\"type\":\"unknown-type\",\"value\":\"12987981103609\"}],\"type\":\"com.symphony.user.mention\"}}"); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 0); | ||
mMessage.setData("{\"0\":{\"id\":[{\"type\":\"unknown-type\",\"value\":\"12987981103609\"}],\"type\":\"com.symphony.user.mention\"}," | ||
+ "\"1\":{\"id\":[{\"type\":\"com.symphony.user.userId\",\"value\":\"12987981103610\"}],\"type\":\"com.symphony.user.mention\"}}"); | ||
mentions = SymMessageParser.getMentions(mMessage); | ||
assertEquals(mentions.size(), 1); | ||
assertEquals(mentions.get(0).longValue(), 12987981103610L); | ||
} | ||
} |