Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix aiohttp disconnect error on websockets #2806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix aiohttp disconnect error on websockets #2806

wants to merge 1 commit into from
+2 −1

Commits on Oct 27, 2024

  1. fix aiohttp disconnect error on websockets 

    aiohttp will throw if the handler doesn't return anything.

```python
14:11:35 aiohttp ERRO Missing return statement on request handler
Traceback (most recent call last):
  File "/Users/steve/conda/envs/port/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 653, in finish_response
    prepare_meth = resp.prepare
                   ^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'prepare'
```

https://docs.aiohttp.org/en/stable/web_quickstart.html#websockets
Signed-off-by: Steve Chan <[email protected]>
    @s22chan
    s22chan committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    e1c1a03 View commit details
    Browse the repository at this point in the history