Move to_columns() JSON creation logic to C++.
#2314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brochington
force-pushed
the
rapidjson-api-experiment
branch
3 times, most recently
from
9c6952d
to
d9c0967
Compare
brochington
force-pushed
the
rapidjson-api-experiment
branch
from
d9c0967
to
f21b69b
Compare
|
Closing in favor of #2315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds creation of a JSON data string from within the core C++ engine. Outputting an already formed JSON string is faster than doing the same in Javascript, while also helping to save a (couple?) (de)serialization round trips.