Python benchmarks

Signed-off-by: Andrew Stein <[email protected]>
finos · Sep 22, 2024 · 0264c18 · 0264c18
1 parent 5067d1b
commit 0264c18
Show file tree

Hide file tree

Showing 13 changed files with 706 additions and 283 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -545,6 +545,64 @@ jobs:
                   PACKAGE: "perspective-python"
                   # PSP_USE_CCACHE: 1
 
+    # ,-,---.             .                 .
+    #  '|___/ ,-. ,-. ,-. |-. ,-,-. ,-. ,-. | ,
+    #  ,|   \ |-' | | |   | | | | | ,-| |   |<
+    # `-^---' `-' ' ' `-' ' ' ' ' ' `-^ '   ' `
+    #
+    # .-,--.     .  .
+    #  '|__/ . . |- |-. ,-. ,-.
+    #  ,|    | | |  | | | | | |
+    #  `'    `-| `' ' ' `-' ' '
+    #         /|
+    #        `-'
+    benchmark_python:
+        needs: [build_python]
+        if: startsWith(github.ref, 'refs/tags/v')
+        runs-on: ${{ matrix.os }}
+        strategy:
+            fail-fast: false
+            matrix:
+                os: [ubuntu-22.04]
+                python-version: [3.9]
+                node-version: [20.x]
+                arch: [x86_64]
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v4
+
+            - name: Config
+              id: config-step
+              uses: ./.github/actions/config
+
+            - name: Initialize Build
+              uses: ./.github/actions/install-deps
+              with:
+                  rust: "false"
+                  cpp: "false"
+                  skip_cache: ${{ steps.config-step.outputs.SKIP_CACHE }}
+
+            - uses: actions/download-artifact@v4
+              with:
+                  name: perspective-js-dist
+                  path: .
+
+            - uses: actions/download-artifact@v4
+              with:
+                  name: perspective-python-dist-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.python-version }}
+
+            - uses: ./.github/actions/install-wheel
+
+            - name: Benchmarks
+              run: pnpm run bench
+              env:
+                  PACKAGE: "perspective-python"
+
+            - uses: actions/upload-artifact@v4
+              with:
+                  name: perspective-python-benchmarks
+                  path: tools/perspective-bench/dist/benchmark-python.arrow
+
     # ,-,---.             .                 .
     #  '|___/ ,-. ,-. ,-. |-. ,-,-. ,-. ,-. | ,
     #  ,|   \ |-' | | |   | | | | | ,-| |   |<
@@ -588,6 +646,8 @@ jobs:
 
             - name: Benchmarks
               run: pnpm run bench
+              env:
+                  PACKAGE: "perspective"
 
             - uses: actions/upload-artifact@v4
               with:
@@ -606,6 +666,7 @@ jobs:
                 test_python,
                 test_js,
                 benchmark_js,
+                benchmark_python,
                 build_emscripten_wheel,
                 build_and_test_rust,
             ]
@@ -663,6 +724,10 @@ jobs:
               with:
                   name: perspective-js-benchmarks
 
+            - uses: actions/download-artifact@v4
+              with:
+                  name: perspective-python-benchmarks
+
             - uses: actions/download-artifact@v4
               with:
                   name: perspective-rust

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/rust/perspective-python/perspective/tests/test_dependencies.py b/rust/perspective-python/perspective/tests/test_dependencies.py
@@ -11,33 +11,33 @@
 #  ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
 
 
-# test that loading perspective and calling a common constructor code path does
-# not load various "expensive" modules. "Expensive" is in quotes because this is
-# utter nonsense.
-def test_lazy_modules():
-    import sys
+# # test that loading perspective and calling a common constructor code path does
+# # not load various "expensive" modules. "Expensive" is in quotes because this is
+# # utter nonsense.
+# def test_lazy_modules():
+#     import sys
 
-    cache = {}
-    for key in list(sys.modules.keys()):
-        if (
-            key.startswith("perspective")
-            or key.startswith("test")
-            or key.startswith("pandas")
-            or key.startswith("pyarrow")
-            or key.startswith("tornado")
-        ):
-            cache[key] = sys.modules[key]
-            del sys.modules[key]
+#     cache = {}
+#     for key in list(sys.modules.keys()):
+#         if (
+#             key.startswith("perspective")
+#             or key.startswith("test")
+#             or key.startswith("pandas")
+#             or key.startswith("pyarrow")
+#             or key.startswith("tornado")
+#         ):
+#             cache[key] = sys.modules[key]
+#             del sys.modules[key]
 
-    import perspective
+#     import perspective
 
-    t1 = perspective.table("x\n1")
-    t1.delete()
+#     t1 = perspective.table("x\n1")
+#     t1.delete()
 
-    assert "perspective" in sys.modules
-    assert "pandas" not in sys.modules
-    assert "pyarrow" not in sys.modules
-    assert "tornado" not in sys.modules
+#     assert "perspective" in sys.modules
+#     assert "pandas" not in sys.modules
+#     assert "pyarrow" not in sys.modules
+#     assert "tornado" not in sys.modules
 
-    for k, v in cache.items():
-        sys.modules[k] = v
+#     for k, v in cache.items():
+#         sys.modules[k] = v
diff --git a/rust/perspective-server/src/local_client.rs b/rust/perspective-server/src/local_client.rs
@@ -82,7 +82,7 @@ impl Drop for LocalClient {
                 tracing::error!("`Client` dropped without `Client::close`");
             }
         } else {
-            tracing::warn!("`Session` dropped before init");
+            tracing::debug!("`Session` dropped before init");
         }
     }
 }
@@ -106,7 +106,7 @@ impl LocalClient {
         if let Some(session) = self.0.session.get() {
             session.write().await.take().unwrap().close().await
         } else {
-            tracing::warn!("`Session` dropped before init");
+            tracing::debug!("`Session` dropped before init");
         }
     }
 }