Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sensitive Data Detection in files like (.csv , .xlsx , json) #761

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Psingle20
Copy link

This PR introduces the checkSensitiveData feature, which enhances the security by scanning files like .csv for vulnerabilities and sensitive information.
The implementation includes:

Functionality:

  • Created a push-action CheckSensitiveData which take this diff and scan the changed files for Sensitive Information.
  • Integrated it push_action chain .
  • Implemented a Test file for the push-action and modified the chain test file to make sure it works with feature added.

I think this Functionality Solves the issue #745
you can run the custom test implemented using command npx mocha test/SensitiveData.test.js
@JamieSlome Please review this PR and suggest any changes necessary

Citi Hackathon
Team Members
Prachit Ingle Psingle20
Shabbir Kaderi shabbirflow
Chaitanya Deshmukh ChaitanyaD48

Copy link

linux-foundation-easycla bot commented Oct 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit df82548
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/671f3836cad9970008742779

@Psingle20 Psingle20 changed the title Feat: Sensitive Data Detection in files like (.csv , .xlsx , json) feat: Sensitive Data Detection in files like (.csv , .xlsx , json) Oct 26, 2024
.husky/commit-msg Outdated Show resolved Hide resolved
Copy link

@laukik-target laukik-target left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is well-structured, handles different file types effectively.
few improvements are recommended:

  • Test Coverage: Add tests for no sensitive data, empty files, and file-not-found scenarios.
  • Optimization: Consider streaming large files for better memory management.

test/CheckSensitive.test.js Outdated Show resolved Hide resolved
@Psingle20
Copy link
Author

@coopernetes @JamieSlome Could you please review this PR and share your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants