cholesky update #338
Merged
cholesky update #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoMDomingues
approved these changes
Nov 7, 2023
test/bwe/MatrixTests.cpp
Outdated
| } | ||
|
|
||
| #define EXPECT_ERROR_LT(a, b, relativeError) \ |
There was a problem hiding this comment.
This is a re-implementation of ASSERT_NEAR/EXPECT_NEAR provided by gtest
There was a problem hiding this comment.
EXPECT_NEAR is comparing with absolute error. This one compares relative error.
It can be done differently I guess.
test/bwe/MatrixTests.cpp
Outdated
| if (d2 != d4) | ||
| { | ||
| if (det(m) == 0 || det(transpose(m)) == 0) |
There was a problem hiding this comment.
this if block is doing nothing
olofkallander
force-pushed
the
choleskyupd
branch
from
a9d9e5e to
d4c2039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will continue on this a bit more. There are a couple of minor things one can do before the decomposition to make it safer, and I have a number of more tests to add.
..