Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch 2.5 #478

Merged
merged 8 commits into from
Dec 21, 2024
Merged

torch 2.5 #478

merged 8 commits into from
Dec 21, 2024

Conversation

catwell
Copy link
Member

@catwell catwell commented Dec 20, 2024

No description provided.

@catwell catwell requested a review from deltheil December 20, 2024 15:08
Copy link
Member

@deltheil deltheil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL - one minor remark

> std(): degrees of freedom is <= 0. Correction should be strictly
> less than the reduction factor (input numel divided by output numel).
- Always initialize the LR scheduler before the first step.
- Correctly call LR scheduler only once per iteration.

See pytorch/pytorch#20124

Note: there is still a problem if you set update_interval as
a number of Epochs.
@catwell catwell merged commit d288e94 into main Dec 21, 2024
3 checks passed
@catwell catwell deleted the pr/torch-2.5 branch December 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants