Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made in Navbar #7702

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Changes made in Navbar #7702

wants to merge 3 commits into from

Conversation

OoONANCY
Copy link

@OoONANCY OoONANCY commented Oct 9, 2024

Problem

The menu structure and functionality needed improvements in accessibility, responsiveness, and feature set.

Solution

Implemented a comprehensive update to menu.js, enhancing its structure, accessibility, and responsiveness while adding new features.

Changes Proposed

  1. Restructured menu items:
  • Removed the 'Others' dropdown structure
  1. Updated social media icons:
  • Replaced text with Font Awesome icons for Instagram, Facebook, LinkedIn, and Twitter
  • Added 'ariaLabel' properties for improved accessibility
  1. Enhanced GitHub stars and forks display:
  • Maintained original implementation using GitHub buttons
  • Added logic to reinitialize GitHub buttons after menu construction
  1. Improved accessibility:
  • Implemented 'ariaLabel' attribute for social media links in the buildMenuHTML function
  1. Implemented responsive design:
  • Added resize event listener for navbar responsive behavior
  • Created logic to hide menu items when exceeding available width
  1. Optimized code structure and performance:
  • Moved menu building logic into a separate buildMenu function
  • Utilized DOMContentLoaded event for proper DOM initialization

Other Changes

  • Added 'Know more' menu item linking to the Hacktoberfest website
  • Added my name to the contributers list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant