Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing binsparse #555

Merged
merged 6 commits into from
May 14, 2024
Merged

fixing binsparse #555

merged 6 commits into from
May 14, 2024

Conversation

willow-ahrens
Copy link
Collaborator

@willow-ahrens willow-ahrens commented May 13, 2024

fixes #523 fixes #537

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (590d037) to head (b9d53ea).
Report is 23 commits behind head on main.

❗ Current head b9d53ea differs from pull request most recent head 653c966. Consider uploading reports for the commit 653c966 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   72.85%   75.67%   +2.82%     
==========================================
  Files          95       95              
  Lines        8522     8573      +51     
==========================================
+ Hits         6209     6488     +279     
+ Misses       2313     2085     -228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willow-ahrens willow-ahrens changed the title seems fine fixing binsparse May 13, 2024
@willow-ahrens
Copy link
Collaborator Author

Also need to rename swizzle->transpose

@willow-ahrens willow-ahrens merged commit e6622c4 into main May 14, 2024
6 checks passed
@willow-ahrens willow-ahrens deleted the wma/fix-fileio branch May 14, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binsparse is out of date matrixmarket reader may be swapping row and column
1 participant