Fix: Validation when id is empty was implemented. Close #3

filesrocket · Apr 10, 2022 · 2707104 · 2707104
1 parent 7053f03
commit 2707104
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "filesrocket-amazons3",
-  "version": "0.0.4",
+  "version": "0.0.5",
   "description": "Filerocket service to manage files from Amazon Storage S3",
   "main": "lib/index.js",
   "types": "lib",

diff --git a/src/services/file.service.ts b/src/services/file.service.ts
@@ -5,7 +5,7 @@ import {
   OutputEntity,
   Query
 } from 'filesrocket'
-import { NotFound } from 'filesrocket/lib/errors'
+import { BadRequest, NotFound } from 'filesrocket/lib/errors'
 import { omitProps } from 'filesrocket/lib/utils'
 import { ManagedUpload } from 'aws-sdk/clients/s3'
 
@@ -73,6 +73,8 @@ export class FileService extends BaseAmazonRocket implements ServiceMethods {
   }
 
   async get (id: string, query: Query = {}): Promise<OutputEntity> {
+    if (!id) throw new BadRequest('Id is empty')
+
     const partialQuery = omitProps(query, ['path'])
 
     const Bucket = query.Bucket || this.options.Bucket

diff --git a/test/file.service.spec.ts b/test/file.service.spec.ts
@@ -81,6 +81,12 @@ describe('Getting files', () => {
       .rejects
       .toThrowError('File does not exist')
   })
+
+  test('Get a file when an empty id is sent', async () => {
+    await expect(findOne(''))
+      .rejects
+      .toThrowError('Id is empty')
+  })
 })
 
 describe('Deleting files', () => {